Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pd version to v2.0.5 #96

Merged
merged 1 commit into from
Nov 1, 2018
Merged

bump pd version to v2.0.5 #96

merged 1 commit into from
Nov 1, 2018

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Oct 31, 2018

What problem does this PR solve?

I'm dealing with pingcap/tidb#7922, and find that after tidb-tools introduce Go module, TiDB will meet this error:

CGO_ENABLED=0 GO111MODULE=on go build   -ldflags '-X "github.com/pingcap/parser/mysql.TiDBReleaseVersion=v2.1.0-rc.3-134-gcf432188b-dirty" -X "github.com/pingcap/tidb/util/printer.TiDBBuildTS=2018-10-31 03:31:00" -X "github.com/pingcap/tidb/util/printer.TiDBGitHash=cf432188beaa2213e62ac7ad8613a1314f8e6da7" -X "github.com/pingcap/tidb/util/printer.TiDBGitBranch=go-module" -X "github.com/pingcap/tidb/util/printer.GoVersion=go version go1.11.1 linux/amd64" ' -o bin/tidb-server tidb-server/main.go
go: finding github.com/pingcap/pd/client latest
tidb-server/main.go:29:2: unknown import path "github.com/pingcap/pd/client": cannot find module providing package github.com/pingcap/pd/client

The pd version is too old, I guess TiDB can't find a compatible version.

What is changed and how it works?

Try to update its pd version

Check List

Tests

  • No code

The pd version is too old, and TiDB module can't find a compatible
version.
@WangXiangUSTC
Copy link
Contributor

LGTM

1 similar comment
@july2993
Copy link
Contributor

july2993 commented Nov 1, 2018

LGTM

@tiancaiamao tiancaiamao merged commit 7b805ea into master Nov 1, 2018
@tiancaiamao tiancaiamao deleted the tiancaiamao/bump-pd branch November 1, 2018 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants