-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: adding missing code of similar definition for test #51035
Conversation
Signed-off-by: AilinKid <314806019@qq.com>
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51035 +/- ##
================================================
+ Coverage 70.5842% 72.4838% +1.8995%
================================================
Files 1467 1467
Lines 434825 438320 +3495
================================================
+ Hits 306918 317711 +10793
+ Misses 108672 100583 -8089
- Partials 19235 20026 +791
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: AilinKid <314806019@qq.com>
@@ -709,6 +709,7 @@ func markChildrenUsedColsForTest(ctx sessionctx.Context, outputSchema *expressio | |||
} | |||
} | |||
childrenUsed = append(childrenUsed, used) | |||
prefixLen += childSchema.Len() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess this line logic is missing compared with markChildrenUsedCols
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test unit-test |
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test tiprow_fast_test |
@AilinKid: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: AilinKid <314806019@qq.com>
What problem does this PR solve?
Issue Number: close #45112
Problem Summary:
What changed and how does it work?
code complement for #45158
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.