planner, executor: fix the logic for inline projection of executors #45158
Conversation
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
size/XXL
ti-chi-bot
bot
added
size/L
winoros
force-pushed
the
fix-for-inline-proj-of-executors
branch
from
97d979a
to
e7987f1
Compare
winoros
force-pushed
the
fix-for-inline-proj-of-executors
branch
from
e7987f1
to
95592dc
Compare
winoros
force-pushed
the
fix-for-inline-proj-of-executors
branch
from
95592dc
to
0a2bcdd
Compare
|
/retest |
|
/retest |
ti-chi-bot
bot
added
needs-cherry-pick-release-6.5
|
@winoros: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, fixdb, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
| p.SetChildren(subPlan) | ||
| } | ||
| // The limit missed its output cols via the protobuf. | ||
| // We need to add it back and do a ResolveIndicies for the later inline projection. |
There was a problem hiding this comment.
limit schema will not always like what its children are, like its children are projection, and it may have been eliminated
| shallowColSlice := make([]*expression.Column, p.schema.Len()) | ||
| copy(shallowColSlice, p.schema.Columns) | ||
| p.schema = expression.NewSchema(shallowColSlice...) | ||
| for i := 0; i < colsNeedResolving; i++ { |
There was a problem hiding this comment.
the only thing we can trust is the column.Index
while there will be some same cols ref to single one problems
What problem does this PR solve?
Issue Number: close #45112
Problem Summary:
What is changed and how it works?
The Physical Projection Elimination permits the case that the parent plan has a column which cannot be found by the child(ren).
The only thing we can rely on during the execution phase is the
Column.Index.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.