Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix an incorrect error message #50739

Merged
merged 2 commits into from
Jan 26, 2024
Merged

br: fix an incorrect error message #50739

merged 2 commits into from
Jan 26, 2024

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jan 26, 2024

What problem does this PR solve?

Issue Number: close #50738

Problem Summary:

What changed and how does it work?

Check List

Tests

  • No need to test
    • I checked and no code files have been changed.

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2024
Copy link

tiprow bot commented Jan 26, 2024

Hi @asddongmen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 26, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 26, 2024
Copy link

ti-chi-bot bot commented Jan 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-26 02:29:04.38458339 +0000 UTC m=+1100585.948881080: ☑️ agreed by Leavrth.
  • 2024-01-26 02:29:57.59455237 +0000 UTC m=+1100639.158850076: ☑️ agreed by BornChanger.

@BornChanger
Copy link
Contributor

/retest

Copy link

tiprow bot commented Jan 26, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Merging #50739 (8924309) into master (34449ef) will increase coverage by 4.2990%.
Report is 4 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50739        +/-   ##
================================================
+ Coverage   70.3547%   74.6537%   +4.2990%     
================================================
  Files          1456       1458         +2     
  Lines        420833     421968      +1135     
================================================
+ Hits         296076     315015     +18939     
+ Misses       104413      87244     -17169     
+ Partials      20344      19709       -635     
Flag Coverage Δ
integration 49.1412% <0.0000%> (?)
unit 70.2645% <0.0000%> (-0.0693%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.7293% <0.0000%> (+6.1455%) ⬆️

@asddongmen
Copy link
Contributor Author

/retest

@asddongmen asddongmen self-assigned this Jan 26, 2024
Copy link

tiprow bot commented Jan 26, 2024

@asddongmen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 078087b into master Jan 26, 2024
20 of 21 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix_incorrect_message branch January 26, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants