*: tidb_opt_use_invisible_indexes support set_var (#50733)

close #50653
pingcap · Jan 26, 2024 · 34449ef · 34449ef
1 parent 799a461
commit 34449ef
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/pkg/sessionctx/variable/setvar_affect.go b/pkg/sessionctx/variable/setvar_affect.go
@@ -53,6 +53,7 @@ var isHintUpdatableVerified = map[string]struct{}{
 	"tidb_opt_disk_factor":                            {},
 	"tidb_opt_concurrency_factor":                     {},
 	"tidb_opt_force_inline_cte":                       {},
+	"tidb_opt_use_invisible_indexes":                  {},
 	"tidb_index_join_batch_size":                      {},
 	"tidb_index_lookup_size":                          {},
 	"tidb_index_serial_scan_concurrency":              {},

diff --git a/tests/integrationtest/r/sessionctx/setvar.result b/tests/integrationtest/r/sessionctx/setvar.result
@@ -1668,6 +1668,18 @@ select /*+ set_var(tidb_init_chunk_size=3) */ @@tidb_init_chunk_size;
 select @@tidb_init_chunk_size;
 @@tidb_init_chunk_size
 1
+select /*+ set_var(tidb_opt_use_invisible_indexes=on) */ @@tidb_opt_use_invisible_indexes;
+@@tidb_opt_use_invisible_indexes
+1
+select @@tidb_opt_use_invisible_indexes;
+@@tidb_opt_use_invisible_indexes
+0
+select /*+ set_var(tidb_opt_use_invisible_indexes=off) */ @@tidb_opt_use_invisible_indexes;
+@@tidb_opt_use_invisible_indexes
+0
+select @@tidb_opt_use_invisible_indexes;
+@@tidb_opt_use_invisible_indexes
+0
 set @@global.max_execution_time=1000;
 select @@max_execution_time;
 @@max_execution_time

diff --git a/tests/integrationtest/t/sessionctx/setvar.test b/tests/integrationtest/t/sessionctx/setvar.test
@@ -680,6 +680,10 @@ select @@tidb_max_chunk_size;
 select @@tidb_init_chunk_size;
 select /*+ set_var(tidb_init_chunk_size=3) */ @@tidb_init_chunk_size;
 select @@tidb_init_chunk_size;
+select /*+ set_var(tidb_opt_use_invisible_indexes=on) */ @@tidb_opt_use_invisible_indexes;
+select @@tidb_opt_use_invisible_indexes;
+select /*+ set_var(tidb_opt_use_invisible_indexes=off) */ @@tidb_opt_use_invisible_indexes;
+select @@tidb_opt_use_invisible_indexes;
 
 set @@global.max_execution_time=1000;
 connect (conn1,localhost,root,,sessionctx__setvar);