ddl, parser: fix the DDL job version using issue (#47915) #47936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #47915
What problem does this PR solve?
Issue Number: close #47912 (Fix this issue on master), close #46306 (Fix this issue on v7.5)
Problem Summary:
After #3993, we using
job.Version
likeSo, when we add the
currentVersion
value(#47818) and have two versions TiDB has an issue.What is changed and how it works?
Use
ReorgMeta
's version instead ofJob
's.Check List
Tests
Case 1
deploy v7.1.0 cluster with 2 tidb.
Then upgrade this cluster to master one by one.
Result: After this PR, upgrade successfully.
Case 2(Manual test in pkg/ddl: fix an issue where endkey usage issues caused index loss (#47818) #47884 )
deploy v7.1.1+ cluster with 1 tidb
set @@global.tidb_ddl_enable_fast_reorg = 0;
Create a table and import 3.5 million rows.
Do alter table t add index idx(a, b);, and when it backfills 700,000+ indexes, kill the cluster.
Then upgrade this cluster to master.
After upgrading successfully, do admin check index t idx
Result: we get Query OK.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.