-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl, parser: fix the DDL job version using issue #47915
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47915 +/- ##
================================================
+ Coverage 71.7443% 73.3131% +1.5687%
================================================
Files 1399 1424 +25
Lines 405476 416429 +10953
================================================
+ Hits 290906 305297 +14391
+ Misses 94846 92130 -2716
+ Partials 19724 19002 -722
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d068c82
to
8d12886
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test check-dev2 |
1 similar comment
/test check-dev2 |
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #47912 (Fix this issue on master), close #46306 (Fix this issue on v7.5)
Problem Summary:
After #3993, we using
job.Version
likeSo, when we add the
currentVersion
value(#47818) and have two versions TiDB has an issue.What is changed and how it works?
Use
ReorgMeta
's version instead ofJob
's.Check List
Tests
Case 1
deploy v7.1.0 cluster with 2 tidb.
Then upgrade this cluster to master one by one.
Result: After this PR, upgrade successfully.
Case 2(Manual test in pkg/ddl: fix an issue where endkey usage issues caused index loss (#47818) #47884 )
deploy v7.1.1+ cluster with 1 tidb
set @@global.tidb_ddl_enable_fast_reorg = 0;
Create a table and import 3.5 million rows.
Do alter table t add index idx(a, b);, and when it backfills 700,000+ indexes, kill the cluster.
Then upgrade this cluster to master.
After upgrading successfully, do admin check index t idx
Result: we get Query OK.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.