disttask: support pause/resume for framework #47037

ywqzzy · 2023-09-18T06:13:04Z

What problem does this PR solve?

Issue Number: ref #46258

Problem Summary:

What is changed and how it works?

When receive pause command

Dispatcher:

pausing state: check all subtasks paused.
paused state: exit the dispatcher.

Manager: pause and cancel all running subtasks, mark running/pending subtasks as Paused.

When receive resume command:

Dispatcher: check all paused subtasks turn into pending state(not in paused state).
If yes, turn task into running state.
Else mark all paused subtasks into pending state.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2023-09-18T06:13:06Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2023-09-18T06:13:30Z

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

disttask/framework/scheduler/manager.go

disttask/framework/scheduler/scheduler.go

disttask/framework/scheduler/manager.go

disttask/framework/storage/task_table.go

Benjamin2037

LGTM

…nd_resume

codecov · 2023-09-20T09:24:31Z

Codecov Report

Merging #47037 (bc953f1) into master (9d29580) will decrease coverage by 0.3037%.
The diff coverage is 64.7343%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47037        +/-   ##
================================================
- Coverage   72.9812%   72.6775%   -0.3037%     
================================================
  Files          1340       1361        +21     
  Lines        400078     406549      +6471     
================================================
+ Hits         291982     295470      +3488     
- Misses        89194      92278      +3084     
+ Partials      18902      18801       -101

Flag	Coverage Δ
integration	`32.3013% <7.6923%> (?)`
unit	`72.9862% <68.7179%> (+0.0049%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`84.9484% <ø> (ø)`
br	`48.7398% <ø> (-4.3509%)`	⬇️

tiprow · 2023-09-21T02:57:56Z

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ywqzzy · 2023-09-21T02:59:04Z

/ok-to-test

ti-chi-bot · 2023-09-21T02:59:19Z

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-09-21T02:59:41Z

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ywqzzy · 2023-09-21T03:20:47Z

/retest

ywqzzy · 2023-09-21T04:38:46Z

/retest

disttask/framework/handle/handle.go

zimulala · 2023-09-21T05:19:40Z

disttask/framework/handle/handle.go

+	if err != nil {
+		return err
+	}
+	task, err := taskManager.GetGlobalTaskByKey(taskKey)


We check this result in line140(through found), so could we remove this check?

We check this result in line140(through found), so could we remove this check?

I will change the resumeTask(int64) to resumeTask(string)

disttask/framework/storage/task_table.go

zimulala

LGTM

ti-chi-bot · 2023-09-21T08:33:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-09-21T08:33:15Z

[LGTM Timeline notifier]

Timeline:

2023-09-18 13:32:11.94047504 +0000 UTC m=+524297.908063092: ☑️ agreed by Benjamin2037.
2023-09-21 08:33:14.513226993 +0000 UTC m=+765560.480815043: ☑️ agreed by zimulala.

zimulala · 2023-09-21T08:33:45Z

Please fix the CI @ywqzzy

wuhuizuo · 2023-09-22T03:25:53Z

/retest

ywqzzy · 2023-09-22T12:21:42Z

/retest

ywqzzy · 2023-09-22T12:32:52Z

/test all

…nd_resume

ywqzzy · 2023-09-23T00:32:50Z

/test all

ywqzzy · 2023-09-23T00:50:35Z

/retest

ywqzzy · 2023-09-23T00:55:08Z

/test tiprow_fast_test

ti-chi-bot · 2023-09-23T00:55:24Z

@ywqzzy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-prisma-test
/test pull-mysql-client-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ywqzzy added 4 commits September 14, 2023 18:15

tmp save

a40afd6

Merge branch 'master' of https://github.com/pingcap/tidb

f298171

Merge branch 'master' of https://github.com/pingcap/tidb

6819d47

demo

2875349

ywqzzy commented Sep 18, 2023

View reviewed changes

disttask/framework/scheduler/manager.go Outdated Show resolved Hide resolved

ywqzzy commented Sep 18, 2023

View reviewed changes

disttask/framework/scheduler/manager.go Outdated Show resolved Hide resolved

ywqzzy commented Sep 18, 2023

View reviewed changes

disttask/framework/scheduler/scheduler.go Outdated Show resolved Hide resolved

Benjamin2037 reviewed Sep 18, 2023

View reviewed changes

disttask/framework/scheduler/manager.go Show resolved Hide resolved

Benjamin2037 reviewed Sep 18, 2023

View reviewed changes

disttask/framework/storage/task_table.go Show resolved Hide resolved

Benjamin2037 approved these changes Sep 18, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 18, 2023

ywqzzy added 2 commits September 20, 2023 17:03

more tests

d6452a4

fix bazel

9956df2

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 20, 2023

ywqzzy added 2 commits September 20, 2023 17:10

Merge branch 'master' of https://github.com/pingcap/tidb into pause_a…

a77e594

…nd_resume

fix

f8cced8

ywqzzy marked this pull request as ready for review September 20, 2023 09:12

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Sep 20, 2023

fix

bf14017

zimulala added the ok-to-test Indicates a PR is ready to be tested. label Sep 21, 2023

fix dispatcher test

bebcbfc

zimulala reviewed Sep 21, 2023

View reviewed changes

address comments

53c9c46

zimulala approved these changes Sep 21, 2023

View reviewed changes

ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 21, 2023

ywqzzy force-pushed the pause_and_resume branch from 12007d2 to 53c9c46 Compare September 22, 2023 12:11

ywqzzy added 2 commits September 23, 2023 08:23

Merge branch 'master' of https://github.com/pingcap/tidb into pause_a…

0fdf70a

…nd_resume

fix test

bc953f1

ti-chi-bot bot merged commit 34438f8 into pingcap:master Sep 23, 2023
12 of 16 checks passed

Yui-Song mentioned this pull request Sep 25, 2023

statistics: there is a 22% performance regression in ANALYZE table #47247

Closed

ywqzzy mentioned this pull request Sep 25, 2023

Enhance distributed task execution framework #46258

Closed

76 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

disttask: support pause/resume for framework #47037

disttask: support pause/resume for framework #47037

ywqzzy commented Sep 18, 2023 •

edited

Loading

ti-chi-bot bot commented Sep 18, 2023

tiprow bot commented Sep 18, 2023

Benjamin2037 left a comment

codecov bot commented Sep 20, 2023 •

edited

Loading

tiprow bot commented Sep 21, 2023

ywqzzy commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

ywqzzy commented Sep 21, 2023

ywqzzy commented Sep 21, 2023

zimulala Sep 21, 2023

ywqzzy Sep 21, 2023

zimulala left a comment

ti-chi-bot bot commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

zimulala commented Sep 21, 2023

wuhuizuo commented Sep 22, 2023

ywqzzy commented Sep 22, 2023

ywqzzy commented Sep 22, 2023

ywqzzy commented Sep 23, 2023

ywqzzy commented Sep 23, 2023

ywqzzy commented Sep 23, 2023

ti-chi-bot bot commented Sep 23, 2023

disttask: support pause/resume for framework #47037

disttask: support pause/resume for framework #47037

Conversation

ywqzzy commented Sep 18, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Sep 18, 2023

tiprow bot commented Sep 18, 2023

Benjamin2037 left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 20, 2023 • edited Loading

Codecov Report

tiprow bot commented Sep 21, 2023

ywqzzy commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

ywqzzy commented Sep 21, 2023

ywqzzy commented Sep 21, 2023

zimulala Sep 21, 2023

Choose a reason for hiding this comment

ywqzzy Sep 21, 2023

Choose a reason for hiding this comment

zimulala left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

[LGTM Timeline notifier]

zimulala commented Sep 21, 2023

wuhuizuo commented Sep 22, 2023

ywqzzy commented Sep 22, 2023

ywqzzy commented Sep 22, 2023

ywqzzy commented Sep 23, 2023

ywqzzy commented Sep 23, 2023

ywqzzy commented Sep 23, 2023

ti-chi-bot bot commented Sep 23, 2023

ywqzzy commented Sep 18, 2023 •

edited

Loading

codecov bot commented Sep 20, 2023 •

edited

Loading