Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: there is a 22% performance regression in ANALYZE table #47247

Closed
Yui-Song opened this issue Sep 25, 2023 · 3 comments · Fixed by #47320
Closed

statistics: there is a 22% performance regression in ANALYZE table #47247

Yui-Song opened this issue Sep 25, 2023 · 3 comments · Fixed by #47320
Assignees
@hawkingrei
Labels
affects-7.4 severity/critical sig/planner SIG: Planner type/bug The issue is confirmed as a bug. type/performance type/regression

Comments

@Yui-Song
Copy link
Contributor

Yui-Song commented Sep 25, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. deploy a cluster with 1 tidb + 6tikv + 2tiflash
  2. restore data of ossinsight (nearly 650GB, with partition tables)
  3. analyze all the tables of the ossinsight database

2. What did you expect to see? (Required)

No performance regression

3. What did you see instead (Required)

image

4. What is your TiDB version? (Required)

good commit: #47132
bad commit: #47037
@Yui-Song Yui-Song added the type/bug The issue is confirmed as a bug. label Sep 25, 2023
@Yui-Song
Copy link
Contributor Author

/severity critical

@ti-chi-bot ti-chi-bot bot added severity/critical may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Sep 25, 2023
@Yui-Song
Copy link
Contributor Author

/type performance
/type regression

@Yui-Song
Copy link
Contributor Author

/remove-label may-affects-7.1
/remove-label may-affects-6.5
/remove-label may-affects-6.1
/remove-label may-affects-5.3
/remove-label may-affects-5.4

@ti-chi-bot ti-chi-bot bot removed may-affects-7.1 may-affects-6.5 may-affects-6.1 may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. labels Sep 25, 2023
@hawkingrei hawkingrei self-assigned this Sep 25, 2023
@hawkingrei hawkingrei mentioned this issue Sep 27, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 28, 2023
@hawkingrei
statistics: add cache for handleGlobalStats's load data (#47320)
aa76278 
close #47247
@ti-chi-bot ti-chi-bot mentioned this issue Sep 29, 2023
Merged
13 tasks
@jebter jebter added the sig/planner SIG: Planner label Oct 7, 2023
ti-chi-bot bot pushed a commit that referenced this issue Oct 7, 2023
@ti-chi-bot
statistics: add cache for handleGlobalStats's load data (#47320) (#47374
0a78639 
)

close #47247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkingrei hawkingrei

Labels
affects-7.4 severity/critical sig/planner SIG: Planner type/bug The issue is confirmed as a bug. type/performance type/regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: add cache for handleGlobalStats's load data hawkingrei/tidb
4 participants
@hawkingrei @jebter @ti-chi-bot @Yui-Song