Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: close duplicateDB when meet error halfway #46685

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Sep 5, 2023

What problem does this PR solve?

Issue Number: close #46682

Problem Summary:

What is changed and how it works?

try to solve a flaky test. We shall see if it won't appear in future

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2023
@tiprow
Copy link

tiprow bot commented Sep 5, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #46685 (b5d4dc7) into master (66fe053) will decrease coverage by 0.7501%.
Report is 37 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46685        +/-   ##
================================================
- Coverage   73.3637%   72.6137%   -0.7501%     
================================================
  Files          1316       1344        +28     
  Lines        395716     408712     +12996     
================================================
+ Hits         290312     296781      +6469     
- Misses        86912      93274      +6362     
- Partials      18492      18657       +165     
Flag Coverage Δ
integration 28.2460% <0.0000%> (?)
unit 73.5863% <0.0000%> (+0.2226%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9609% <ø> (-0.0080%) ⬇️
br 47.7524% <0.0000%> (-4.6891%) ⬇️
📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap).

@lance6716
Copy link
Contributor Author

/cc @hawkingrei

@ti-chi-bot ti-chi-bot bot requested a review from hawkingrei September 6, 2023 02:17
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 7, 2023
@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a test?Or we have this test(If it has this test, please add it to PR description)

@lance6716
Copy link
Contributor Author

Do we need to add a test?Or we have this test(If it has this test, please add it to PR description)

Updated, it's #46682

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. do-not-merge/needs-tests-checked labels Sep 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-07 07:22:31.396050571 +0000 UTC m=+2602915.945066557: ☑️ agreed by xhebox.
  • 2023-09-08 08:03:25.023213131 +0000 UTC m=+2691769.572229103: ☑️ agreed by hawkingrei.

@lance6716
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Sep 8, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Sep 8, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 58a2dad into pingcap:master Sep 8, 2023
28 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goleak github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker
5 participants