test: close duplicateDB when meet error halfway (#46685)

close #46682
pingcap · Sep 8, 2023 · 58a2dad · 58a2dad
1 parent 2738160
commit 58a2dad
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/br/pkg/lightning/backend/local/local.go b/br/pkg/lightning/backend/local/local.go
@@ -506,7 +506,13 @@ func NewBackend(
 	tls *common.TLS,
 	config BackendConfig,
 	regionSizeGetter TableRegionSizeGetter,
-) (*Backend, error) {
+) (b *Backend, err error) {
+	var duplicateDB *pebble.DB
+	defer func() {
+		if err != nil && duplicateDB != nil {
+			_ = duplicateDB.Close()
+		}
+	}()
 	config.adjust()
 	pdCtl, err := pdutil.NewPdController(ctx, config.PDAddr, tls.TLSConfig(), tls.ToPDSecurityOption())
 	if err != nil {
@@ -532,7 +538,6 @@ func NewBackend(
 		}
 	}
 
-	var duplicateDB *pebble.DB
 	if config.DupeDetectEnabled {
 		duplicateDB, err = openDuplicateDB(config.LocalStoreDir)
 		if err != nil {