Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove skip #45974

Merged
merged 2 commits into from
Aug 11, 2023
Merged

*: remove skip #45974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d3478
*: remove skip
hawkingrei Aug 10, 2023
1778b2e
*: remove skip
hawkingrei Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion executor/infoschema_reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ import (
)

func TestInspectionTables(t *testing.T) {
t.Skip("unstable, skip it and fix it before 20210624")
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
instances := []string{
Expand Down
4 changes: 1 addition & 3 deletions executor/merge_join_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,7 @@ func TestShuffleMergeJoinInDisk(t *testing.T) {
}

func TestMergeJoinInDisk(t *testing.T) {
t.Skip("unstable, skip it and fix it before 20210618")
restore := config.RestoreFunc()
defer restore()
defer config.RestoreFunc()()
config.UpdateGlobal(func(conf *config.Config) {
conf.TempStoragePath = t.TempDir()
})
Expand Down
1 change: 0 additions & 1 deletion executor/test/analyzetest/analyze_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,6 @@ func TestDefaultValForAnalyze(t *testing.T) {
}

func TestAnalyzeFullSamplingOnIndexWithVirtualColumnOrPrefixColumn(t *testing.T) {
t.Skip("unstable, skip it and fix it before 20210624")
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)

Expand Down
10 changes: 3 additions & 7 deletions planner/core/prepare_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ import (
"testing"
"time"

"github.com/pingcap/tidb/errno"
"github.com/pingcap/tidb/executor"
"github.com/pingcap/tidb/expression"
"github.com/pingcap/tidb/infoschema"
"github.com/pingcap/tidb/kv"
"github.com/pingcap/tidb/metrics"
"github.com/pingcap/tidb/parser"
"github.com/pingcap/tidb/parser/auth"
"github.com/pingcap/tidb/parser/terror"
"github.com/pingcap/tidb/planner/core"
"github.com/pingcap/tidb/session"
"github.com/pingcap/tidb/sessionctx/variable"
Expand Down Expand Up @@ -720,7 +720,6 @@ func TestPrepareCacheNow(t *testing.T) {
}

func TestPrepareOverMaxPreparedStmtCount(t *testing.T) {
t.Skip("unstable, skip it and fix it before 20210705")
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
Expand Down Expand Up @@ -752,18 +751,15 @@ func TestPrepareOverMaxPreparedStmtCount(t *testing.T) {
for i := 1; ; i++ {
prePrepared = readGaugeInt(metrics.PreparedStmtGauge)
if prePrepared >= 2 {
_, err := tk.Exec(`prepare stmt` + strconv.Itoa(i) + ` from "select 1"`)
require.True(t, terror.ErrorEqual(err, variable.ErrMaxPreparedStmtCountReached))
tk.MustGetErrCode(`prepare stmt`+strconv.Itoa(i)+` from "select 1"`, errno.ErrMaxPreparedStmtCountReached)
break
}
_, err := tk.Exec(`prepare stmt` + strconv.Itoa(i) + ` from "select 1"`)
require.NoError(t, err)
tk.MustExec(`prepare stmt` + strconv.Itoa(i) + ` from "select 1"`)
}
}

// unit test for issue https://github.com/pingcap/tidb/issues/8518
func TestPrepareTableAsNameOnGroupByWithCache(t *testing.T) {
t.Skip("unstable, skip it and fix it before 20210702")
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec(`set tidb_enable_prepared_plan_cache=1`)
Expand Down