Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove skip #45974

Merged
merged 2 commits into from
Aug 11, 2023
Merged

*: remove skip #45974

merged 2 commits into from
Aug 11, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 10, 2023

What problem does this PR solve?

Issue Number: ref #45985

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #45974 (1778b2e) into master (c7c7000) will decrease coverage by 1.6529%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45974        +/-   ##
================================================
- Coverage   74.7873%   73.1344%   -1.6529%     
================================================
  Files          1293       1300         +7     
  Lines        398010     399705      +1695     
================================================
- Hits         297661     292322      -5339     
- Misses        80969      88800      +7831     
+ Partials      19380      18583       -797     
Flag Coverage Δ
integration 26.1493% <ø> (-20.3190%) ⬇️
unit 73.3455% <ø> (+0.0002%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0494% <ø> (ø)
br 51.1460% <ø> (-13.5698%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-11 02:12:58.599158945 +0000 UTC m=+251543.148174930: ☑️ agreed by lance6716.
  • 2023-08-11 02:15:50.876604944 +0000 UTC m=+251715.425620930: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit cfefc83 into pingcap:master Aug 11, 2023
5 of 9 checks passed
@hawkingrei hawkingrei deleted the remove_skip_0810 branch August 11, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants