Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support lowerBound and IterReserve for unionScan #45315

Merged
merged 9 commits into from
Jul 18, 2023
Merged

*: support lowerBound and IterReserve for unionScan #45315

merged 9 commits into from
Jul 18, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Jul 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45314

Problem Summary: support lowerBound and IterReserve for unionScan. Need tikv/client-go#883

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Twice speed up TableRead performance.

LowerBound
BenchmarkUnionScanIndexReadDescRead
   10316	    116779 ns/op	   85377 B/op	    1139 allocs/op
BenchmarkUnionScanTableReadDescRead
   17587	     67679 ns/op	   33275 B/op	     493 allocs/op
BenchmarkUnionScanIndexLookUpDescRead
   12888	     91659 ns/op	   78332 B/op	     909 allocs/op

Master
BenchmarkUnionScanIndexReadDescRead
   10032	    115868 ns/op	   85542 B/op	    1141 allocs/op
BenchmarkUnionScanTableReadDescRead
    9450	    120510 ns/op	   84462 B/op	    1013 allocs/op
BenchmarkUnionScanIndexLookUpDescRead
   11187	     93701 ns/op	   78350 B/op	     909 allocs/op

@ti-chi-bot ti-chi-bot bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 12, 2023
@tiprow
Copy link

tiprow bot commented Jul 12, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 12, 2023
@Defined2014 Defined2014 mentioned this pull request Jul 12, 2023
Merged
@bb7133
Copy link
Member

bb7133 commented Jul 13, 2023

Please update the 'Tests' part of Checklist:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 13, 2023
@bb7133 bb7133 added the require-LGT3 Indicates that the PR requires three LGTM. label Jul 13, 2023
@bb7133 bb7133 requested a review from crazycs520 July 13, 2023 06:05
bb7133
bb7133 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-13 05:15:52.684584157 +0000 UTC m=+568244.454922869: ☑️ agreed by xhebox.
  • 2023-07-13 06:06:30.482046484 +0000 UTC m=+571282.252385197: ☑️ agreed by bb7133.

@bb7133
Copy link
Member

bb7133 commented Jul 13, 2023

PTAL @crazycs520

@Defined2014
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@Defined2014
Copy link
Contributor Author

Need merge client-go tikv/client-go#883 patch firstly.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, tiancaiamao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bb7133,tiancaiamao,xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2023
@Defined2014
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@Defined2014
Copy link
Contributor Author

/test check-dev

@tiprow
Copy link

tiprow bot commented Jul 18, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit f1b9da1 into pingcap:master Jul 18, 2023
@Defined2014 Defined2014 deleted the lowerBound branch July 18, 2023 07:49
@Defined2014 Defined2014 mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@xhebox xhebox xhebox approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. require-LGT3 Indicates that the PR requires three LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support lowerBound and IterReserve for UnionScan related struct
4 participants
@Defined2014 @bb7133 @tiancaiamao @xhebox