Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support lowerBound and IterReserve for UnionScan related struct #45314

Closed
Defined2014 opened this issue Jul 12, 2023 · 0 comments · Fixed by #45315
Closed

support lowerBound and IterReserve for UnionScan related struct #45314

Defined2014 opened this issue Jul 12, 2023 · 0 comments · Fixed by #45315
Assignees
@Defined2014
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@Defined2014
Copy link
Contributor

Enhancement

Client-go only have SnapshotIter for MemDB, we could add SnapshotIterReverse function and used it in UnionScan to improve order by decs queries.

Related lines
https://github.com/tikv/client-go/blob/e540aa3b9657c4913daafcbc543d7a101488fa50/internal/unionstore/memdb_snapshot.go#L50-L61

and

tidb/executor/mem_reader.go

Line 151 in bbae44b

// TODO: After refine `IterReverse`, remove below logic and use `IterReverse` when do reverse scan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Defined2014 Defined2014

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: support lowerBound and IterReserve for unionScan Defined2014/tidb
1 participant
@Defined2014