-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix cte nil pointer error when got multiple apply (#44782) #44846
Merged
ti-chi-bot
merged 5 commits into
pingcap:release-7.1
from
ti-chi-bot:cherry-pick-44782-to-release-7.1
Jul 7, 2023
Merged
*: fix cte nil pointer error when got multiple apply (#44782) #44846
ti-chi-bot
merged 5 commits into
pingcap:release-7.1
from
ti-chi-bot:cherry-pick-44782-to-release-7.1
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.1
This PR is cherry-picked to release-7.1 from a source PR.
labels
Jun 20, 2023
ti-chi-bot
bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jun 20, 2023
ti-chi-bot
bot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Jul 6, 2023
This reverts commit 46c2dbf.
…k-44782-to-release-7.1
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
ti-chi-bot
bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jul 7, 2023
wshwsh12
approved these changes
Jul 7, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Jul 7, 2023
XuHuaiyu
approved these changes
Jul 7, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Jul 7, 2023
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jul 7, 2023
ti-chi-bot
removed
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jul 24, 2023
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.1
This PR is cherry-picked to release-7.1 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #44782
What problem does this PR solve?
Issue Number: close #44774
Problem Summary:
The following plan:
If
CTE-1
andCTE-2
both access the same CTE Producer(a.k.a. same CTE defition), we useCTEExec.IsInApply
to control whether reopen CTEStorage.But
CTE.IsInApply
is not enough here, because CTE-1 and CTE-2 only need to reopen when Apply-1 runs, no need to reopen when Apply-2 runs.What is changed and how it works?
Before: Always reopen CTEStorage/CTEProducer when
CTE.IsInApply
is true.After: Only reopen CTEStorage/CTEProducer when the data of corCol changes.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.