-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix cte nil pointer error when got multiple apply #44782
*: fix cte nil pointer error when got multiple apply #44782
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
/test check_dev2 |
@guo-shaoge: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
This reverts commit 2c13472.
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test build |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This reverts commit 46c2dbf.
This reverts commit ca69374.
What problem does this PR solve?
Issue Number: close #44774
Problem Summary:
The following plan:
If
CTE-1
andCTE-2
both access the same CTE Producer(a.k.a. same CTE defition), we useCTEExec.IsInApply
to control whether reopen CTEStorage.But
CTE.IsInApply
is not enough here, because CTE-1 and CTE-2 only need to reopen when Apply-1 runs, no need to reopen when Apply-2 runs.What is changed and how it works?
Before: Always reopen CTEStorage/CTEProducer when
CTE.IsInApply
is true.After: Only reopen CTEStorage/CTEProducer when the data of corCol changes.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.