-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: remove statistics.Column.Count (#43033) #44405
statistics: remove statistics.Column.Count (#43033) #44405
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Too much conflict. I will manually do the cherry pick(#44406). |
This is an automated cherry-pick of #43033
What problem does this PR solve?
Issue Number: ref #42160 close #44404
Problem Summary:
What is changed and how it works?
Remove
statistics.Column.Count
.Before the PR, in order to maintain
statistics.Column.Count
, we need to readmysql.stats_top_n
andmysql.stats_buckets
for each column when init stats, which is time-consuming. On the other hand, the usage ofstatistics.Column.Count
is limited. We modify(*DataSource).getColumnNDV
to get rid ofstatistics.Column.Count
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.