Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculating topn count in InitStats takes too much time #44404

Closed
xuyifangreeneyes opened this issue Jun 5, 2023 · 2 comments · Fixed by #43033
Closed

calculating topn count in InitStats takes too much time #44404

xuyifangreeneyes opened this issue Jun 5, 2023 · 2 comments · Fixed by #43033
Labels
affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 component/statistics severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@xuyifangreeneyes
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

In InitStats, we need to call select sum(count) from mysql.stats_top_n where table_id = xxx and is_index = 0 and hist_id = xxx for each column, which is time-consuming.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

v6.5
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jun 5, 2023
@xuyifangreeneyes xuyifangreeneyes added affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 labels Jun 5, 2023
@ti-chi-bot ti-chi-bot bot removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-6.1 may-affects-6.5 labels Jun 5, 2023
@xuyifangreeneyes xuyifangreeneyes mentioned this issue Apr 14, 2023
Merged
12 tasks
@xuyifangreeneyes
Copy link
Contributor Author

The issue is created for tracking the cherry pick of #43033

@xuyifangreeneyes
Copy link
Contributor Author

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this issue Jun 5, 2023
Closed
12 tasks
@xuyifangreeneyes xuyifangreeneyes mentioned this issue Jun 5, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 5, 2023
@xuyifangreeneyes
statistics: refine index/column stats methods and remove statistics.C…
546e491 
…olumn.Count (#44406)

ref #42160, close #44404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 component/statistics severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: remove statistics.Column.Count xuyifangreeneyes/tidb
1 participant
@xuyifangreeneyes