Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind: fix global binding hint for resource groups (#43738) #43780

Merged
merged 4 commits into from
May 15, 2023
Merged

bind: fix global binding hint for resource groups (#43738) #43780

merged 4 commits into from
May 15, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43738

What problem does this PR solve?

Issue Number: close #43736, Ref #38825

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

HuSharp and others added 4 commits May 12, 2023 12:43
@HuSharp @ti-chi-bot
update
6e0b10d 
Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp @ti-chi-bot
update bazel
2c9d9b4 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp @ti-chi-bot
update
16e5fd2 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp @ti-chi-bot
update
4e67653 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
2 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels May 12, 2023
@HuSharp
Copy link
Contributor

HuSharp commented May 12, 2023

/retest

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 14, 2023
@nolouch
Copy link
Member

nolouch commented May 14, 2023

/retest-required

@HuSharp
Copy link
Contributor

HuSharp commented May 15, 2023

@nolouch @glorv PTAL, thx!

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 15, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 15, 2023
@nolouch
Copy link
Member

nolouch commented May 15, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 15, 2023

@nolouch: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glorv
Copy link
Contributor

glorv commented May 15, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 15, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4e67653

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2217379 into pingcap:release-7.1 May 15, 2023
@HuSharp HuSharp deleted the cherry-pick-43738-to-release-7.1 branch May 15, 2023 03:55
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@nolouch nolouch nolouch approved these changes

Assignees

@HuSharp HuSharp

Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @HuSharp @nolouch @glorv @VelocityLight