Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind: fix global binding hint for resource groups #43738

Merged
merged 4 commits into from
May 12, 2023
Merged

bind: fix global binding hint for resource groups #43738

merged 4 commits into from
May 12, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented May 12, 2023

What problem does this PR solve?

Issue Number: close #43736, Ref #38825

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@HuSharp
update
271742e 
Signed-off-by: husharp <ihusharp@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2023
@nolouch nolouch changed the title bind: fix binding hint for resource groups bind: fix global binding hint for resource groups May 12, 2023
@HuSharp
update bazel
0ea43c6 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023

@CabinfeverB: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

nolouch
nolouch approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 12, 2023
@nolouch
Copy link
Member

nolouch commented May 12, 2023

ptal @glorv

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2023
@glorv
Copy link
Contributor

glorv commented May 12, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0ea43c6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2023
@glorv
Copy link
Contributor

glorv commented May 12, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2023
glorv
glorv reviewed May 12, 2023
View reviewed changes
planner/optimize.go Outdated Show resolved Hide resolved
@HuSharp
update
937c166 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2023
@glorv
Copy link
Contributor

glorv commented May 12, 2023

/unhold
/merge

@HuSharp
update
6b8dba7 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 937c166

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels May 12, 2023
@HuSharp
Copy link
Contributor Author

HuSharp commented May 12, 2023 •
edited
Loading

@glorv delete a redundant line, plz add merge label again, thx!

@glorv
Copy link
Contributor

glorv commented May 12, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6b8dba7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0af1bd7 into pingcap:master May 12, 2023
@HuSharp HuSharp deleted the fix_binding_hint_resource_group branch May 12, 2023 12:43
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
2 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43780.

ti-chi-bot bot pushed a commit that referenced this pull request May 15, 2023
@ti-chi-bot
bind: fix global binding hint for resource groups (#43738) (#43780)
2217379 
ref #38825, close #43736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@nolouch nolouch nolouch approved these changes

@winoros winoros winoros approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bind: support binding hint to resource group
6 participants
@HuSharp @nolouch @glorv @ti-chi-bot @winoros @CabinfeverB