Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: ignore Preprocess error for the prefetchPointPlanKeys optimization (#39945) #43059

Merged
merged 1 commit into from
Apr 1, 2024
Merged

server: ignore Preprocess error for the prefetchPointPlanKeys optimization (#39945) #43059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2048,9 +2048,9 @@
return nil, nil
}
// TODO: the preprocess is run twice, we should find some way to avoid do it again.
// TODO: handle the PreprocessorReturn.
if err = plannercore.Preprocess(ctx, cc.getCtx(), stmt); err != nil {
return nil, err
// error might happen, see https://github.com/pingcap/tidb/issues/39664
return nil, nil

Check warning on line 2053 in server/conn.go

View check run for this annotation

Codecov / codecov/patch

server/conn.go#L2052-L2053 

Added lines #L2052 - L2053 were not covered by tests
}
p := plannercore.TryFastPlan(cc.ctx.Session, stmt)
pointPlans[i] = p
Expand Down
Loading