Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: ignore Preprocess error for the prefetchPointPlanKeys optimization (#39945) #43059

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39945

What problem does this PR solve?

Issue Number: close #39664

Problem Summary:

What is changed and how it works?

The error is throw from the Preprocess() in the prefetchPointPlanKeys.
prefetchPointPlanKeys is quite tricky, it does not reuse the common code path for the sake of performance.

Premature optimization is the root of all evil.
This tricky optimization helped us improve the performance by 100 times and won the deal, and now it's time to pay the (technical) debt.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Apr 14, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot closed this Aug 10, 2023
@Defined2014 Defined2014 reopened this Apr 1, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 08:47:15.170709251 +0000 UTC m=+260896.698249789: ☑️ agreed by Defined2014.
  • 2024-04-01 08:49:11.865077112 +0000 UTC m=+261013.392617658: ☑️ agreed by tiancaiamao.

@Defined2014
Copy link
Contributor

/retest

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@1a2b9bf). Click here to learn what that means.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #43059   +/-   ##
================================================
  Coverage               ?   78.0310%           
================================================
  Files                  ?       1096           
  Lines                  ?     384847           
  Branches               ?          0           
================================================
  Hits                   ?     300300           
  Misses                 ?      69180           
  Partials               ?      15367           

@ti-chi-bot ti-chi-bot bot merged commit 902758d into pingcap:release-6.5 Apr 1, 2024
9 of 11 checks passed
@Defined2014 Defined2014 deleted the cherry-pick-39945-to-release-6.5 branch April 1, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants