-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: ignore Preprocess error for the prefetchPointPlanKeys
optimization (#39945)
#43059
server: ignore Preprocess error for the prefetchPointPlanKeys
optimization (#39945)
#43059
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #43059 +/- ##
================================================
Coverage ? 78.0310%
================================================
Files ? 1096
Lines ? 384847
Branches ? 0
================================================
Hits ? 300300
Misses ? 69180
Partials ? 15367 |
This is an automated cherry-pick of #39945
What problem does this PR solve?
Issue Number: close #39664
Problem Summary:
What is changed and how it works?
The error is throw from the
Preprocess()
in theprefetchPointPlanKeys
.prefetchPointPlanKeys
is quite tricky, it does not reuse the common code path for the sake of performance.Premature optimization is the root of all evil.
This tricky optimization helped us improve the performance by 100 times and won the deal, and now it's time to pay the (technical) debt.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.