Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl/schematracker: fix SetDDL will cause data race #36768

Merged
merged 8 commits into from
Aug 1, 2022
Merged

ddl/schematracker: fix SetDDL will cause data race #36768

merged 8 commits into from
Aug 1, 2022

Conversation

lance6716
Copy link
Contributor

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: close #36766

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
ddl/schematracker: fix SetDDL will cause data race
621c1d8 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2022
@lance6716
remove unused
6455319 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix a test
8b7124d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cee4852e05ac7d585c6a82a4b6a92a309ae65846

@lance6716
Copy link
Contributor Author

/run_build
/run_mysql-test

@lance6716
Copy link
Contributor Author

/build

@lance6716
Copy link
Contributor Author

/run-mysql-test

@lance6716
Copy link
Contributor Author

all tests passed @hawkingrei

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 1, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3e87436

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@hawkingrei
Copy link
Member

/run-build
/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit cc2fcfc into pingcap:master Aug 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 7 min 52 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 33 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 20 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 22 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 27 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo pushed a commit to morgo/tidb that referenced this pull request Aug 1, 2022
@lance6716 @morgo
ddl/schematracker: fix SetDDL will cause data race (pingcap#36768)
3db73b4 
close pingcap#36766
morgo added a commit to morgo/tidb that referenced this pull request Aug 1, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into sysvar-api-cleanup
a462ff1 
* upstream/master:
  ddl/schematracker: fix SetDDL will cause data race (pingcap#36768)
  planner: check virtual column for tiflash (pingcap#36771)
  *: replace defer clean with t.Cleanup (pingcap#36722)
  ddl: fix inaccurate row_count for `admin show ddl jobs` (pingcap#36716)
  config, sysvar: add config `instance.enable_ddl` and sysvar `tidb_enable_ddl` (pingcap#35425)
  *: enable part revive for all code (pingcap#36703)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the domain.(*Domain).SetDDL()
5 participants
@lance6716 @ti-chi-bot @sre-bot @hawkingrei @tiancaiamao