Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: enable part revive for all code #36703

Merged
merged 16 commits into from
Aug 1, 2022
Merged

*: enable part revive for all code #36703

merged 16 commits into from
Aug 1, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 29, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Problem Summary:

revive enable some rule to check all the tidb repo code.

the main problem is to fix the empty-line, If-Return and so on.

BTW, I upgrade the golangci-linter

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2022
@hawkingrei hawkingrei changed the title *: all party revive for all code *: enable part revive for all code Jul 29, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/19336ba32ea6c30883aac61829fa2a06fe196e3a

@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Jul 29, 2022
@hawkingrei hawkingrei requested a review from xhebox July 29, 2022 08:05
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2022
@hawkingrei
Copy link
Member Author

/run-build

@hawkingrei hawkingrei requested a review from a team as a code owner July 29, 2022 12:49
@hawkingrei hawkingrei force-pushed the all_revive branch 9 times, most recently from ebffc5a to 73295ac Compare July 30, 2022 15:15
@hawkingrei hawkingrei requested a review from tisonkun July 30, 2022 15:17
@hawkingrei hawkingrei force-pushed the all_revive branch 4 times, most recently from 5da435c to cdbd137 Compare July 30, 2022 15:58
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
xhebox
xhebox reviewed Aug 1, 2022
View reviewed changes
ddl/db_rename_test.go Outdated Show resolved Hide resolved
ddl/index.go Outdated Show resolved Hide resolved
ddl/index.go Outdated Show resolved Hide resolved
ddl/index.go Outdated Show resolved Hide resolved
@hawkingrei
*: all party revive for all code
d2219c8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: all party revive for all code
68f968f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: all party revive for all code
9534605 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: all party revive for all code
d1813a7 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: all party revive for all code
33cb3ca 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: all party revive for all code
93737e4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: all party revive for all code
9dd7322 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: all party revive for all code
cf9036f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: all party revive for all code
895ae68 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
enable revive
19c7429 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
enable revive
0e30de0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
enable revive
213f109 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
enable revive
8f131d0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: remove useless param
638394f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
enable revive
abd605f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@qw4990
Copy link
Contributor

qw4990 commented Aug 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: abd605f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@hawkingrei hawkingrei requested a review from xhebox August 1, 2022 05:56
@ti-chi-bot ti-chi-bot merged commit 158ba1a into pingcap:master Aug 1, 2022
@hawkingrei hawkingrei deleted the all_revive branch August 1, 2022 06:03
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 6 min 7 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 29 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 7 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 5 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 27 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 46 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo pushed a commit to morgo/tidb that referenced this pull request Aug 1, 2022
@hawkingrei @morgo
*: enable part revive for all code (pingcap#36703)
f1f08b4
morgo added a commit to morgo/tidb that referenced this pull request Aug 1, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into sysvar-api-cleanup
a462ff1 
* upstream/master:
  ddl/schematracker: fix SetDDL will cause data race (pingcap#36768)
  planner: check virtual column for tiflash (pingcap#36771)
  *: replace defer clean with t.Cleanup (pingcap#36722)
  ddl: fix inaccurate row_count for `admin show ddl jobs` (pingcap#36716)
  config, sysvar: add config `instance.enable_ddl` and sysvar `tidb_enable_ddl` (pingcap#35425)
  *: enable part revive for all code (pingcap#36703)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Yisaer Yisaer Yisaer approved these changes

@tisonkun tisonkun tisonkun approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hawkingrei @ti-chi-bot @sre-bot @qw4990 @xhebox @Yisaer @tisonkun