-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry: sync the concurrent map access of built-in func usage #32618
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/70e67ebd13639e673e88bb2e445152c62b5f06a6 |
/hold Since the telemetry module is not the only one who assumes "there is no concurrent modifications", there should be a better way to solve this issue(For example, use a different context for build side and probe side when joining view system tables). |
@tangenta: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixed by #33946. |
What problem does this PR solve?
Issue Number: close #32459, related to #26234
Problem Summary:
The panic is caused by the concurrent map access(click the details below to see):
What is changed and how it works?
This PR synchronize the map access.
Check List
Tests
Side effects
Documentation
Release note