-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry: Add telemetry information about builtin functions usage #26234
telemetry: Add telemetry information about builtin functions usage #26234
Conversation
/run-all-tests |
1 similar comment
/run-all-tests |
/cc @kaixu120811 PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cc @breeswish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM�
@LittleFall: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
test need fix:
|
/run-all-tests |
@Vancior: Request changes is only allowed for the reviewers in list. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@lucklove
/sig tiup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/remove-sig tiup |
/remove-sig sql-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
1 similar comment
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3ea15b4
|
1 similar comment
This pull request has been accepted and is ready to merge. Commit hash: 3ea15b4
|
/sig tiup |
Please add details about this to https://docs.pingcap.com/tidb/stable/telemetry once merged |
doc pr: pingcap/docs-cn#6841 |
@lzmhhh123 is performing additional review for this PR. |
What problem does this PR solve?
Issue Number: close #25947
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Use a
map[string]uint32
to record builtin functions usage information in each telemetry window.Since for each expression in a single SQL query will be accessed by
expressionRewriter
, we can record the builtin functions usage information as soon asexpressionRewriter.newFunction
is invoked. Then we can submit the result toGlobalBuiltinFunctionUsageCollector
after executing the query.After adding this field, the telemetry data will look like:
Check List
Tests
Side effects
Documentation
Release note