Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support BatchPointGet for partition table #21857

Closed
wants to merge 3 commits into from
Closed

planner: support BatchPointGet for partition table #21857

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
283e664
support BatchPointGet for partition table
xiaodong-ji Dec 17, 2020
3d088b0
fixing code logic
xiaodong-ji Dec 17, 2020
3717a24
Merge branch 'master' into planner_21847
xiaodong-ji Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion planner/core/find_best_task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ func (ds *DataSource) findBestTask(prop *property.PhysicalProperty, planCounter
p: dual,
}, cntPlan, nil
}
canConvertPointGet := (!ds.isPartition && len(path.Ranges) > 0) || (ds.isPartition && len(path.Ranges) == 1)
canConvertPointGet := len(path.Ranges) > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lysu For partition table, multi-range can also triger Get/BatchGet operation, right?

Copy link
Contributor

@lysu lysu Dec 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess maybe some reason let #14775 (comment) only support single range? @lzmhhh123 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot the reason. Maybe the previous point get can't handle the partition table.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh...current point get can handle the partition

canConvertPointGet = canConvertPointGet && candidate.path.StoreType != kv.TiFlash
if !candidate.path.IsIntHandlePath {
canConvertPointGet = canConvertPointGet &&
Expand Down