-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support BatchPointGet for partition table #21857
Conversation
planner/core/find_best_task.go
Outdated
@@ -691,7 +691,7 @@ func (ds *DataSource) findBestTask(prop *property.PhysicalProperty, planCounter | |||
p: dual, | |||
}, cntPlan, nil | |||
} | |||
canConvertPointGet := (!ds.isPartition && len(path.Ranges) > 0) || (ds.isPartition && len(path.Ranges) == 1) | |||
canConvertPointGet := (!ds.isPartition || ds.isPartition) && len(path.Ranges) > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(!ds.isPartition || ds.isPartition)
always true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -691,7 +691,7 @@ func (ds *DataSource) findBestTask(prop *property.PhysicalProperty, planCounter | |||
p: dual, | |||
}, cntPlan, nil | |||
} | |||
canConvertPointGet := (!ds.isPartition && len(path.Ranges) > 0) || (ds.isPartition && len(path.Ranges) == 1) | |||
canConvertPointGet := len(path.Ranges) > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lysu For partition table, multi-range can also triger Get
/BatchGet
operation, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess maybe some reason let #14775 (comment) only support single range? @lzmhhh123 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot the reason. Maybe the previous point get can't handle the partition table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh...current point get can handle the partition
I think only modifying
The |
@xiaodong-ji please add some tests to ensure the correctness and performance improvements, we need these tests to check:
|
@xiaodong-ji, please update your pull request. |
1 similar comment
@xiaodong-ji, please update your pull request. |
@xiaodong-ji PR closed due to no update for a long time. Feel free to reopen it anytime. |
What problem does this PR solve?
Issue Number: close #21847
Problem Summary: Partition table didn't support BatchPointGet.
What is changed and how it works?
What's Changed:
How it Works:
Check List
Tests
Release note