-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*:Record the time consuming of memory operation of Insert Executor in Runtime Information (#19574) #20187
*:Record the time consuming of memory operation of Insert Executor in Runtime Information (#19574) #20187
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
7 similar comments
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
executor/insert_common.go
Outdated
@@ -929,12 +938,37 @@ func (e *InsertValues) handleWarning(err error) { | |||
sc.AppendWarning(err) | |||
} | |||
|
|||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyz0309 Please fix conflicts.
Signed-off-by: jyz0309 <45495947@qq.com>
…into release-4.0-bb354b0c3022
Signed-off-by: jyz0309 <45495947@qq.com>
Signed-off-by: jyz0309 <45495947@qq.com>
Signed-off-by: jyz0309 <45495947@qq.com>
Signed-off-by: jyz0309 <45495947@qq.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@qw4990 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
cherry-pick #19574 to release-4.0
What problem does this PR solve?
Issue Number: close #19512
Problem Summary:
What is changed and how it works?
What's Changed:
add two extra time-consuming sections in runtime information and trace span
How it Works:
Split inspection and insertion into two parts, and time each part
Related changes
pingcap/exector
:Check List
Tests
Side effects
After this pr:
Release note