Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record the time consuming of memory operation of Insert Executor in Runtime Information #19512

Closed
SunRunAway opened this issue Aug 27, 2020 · 4 comments · Fixed by #19574
Closed
Labels
challenge-program sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.

Comments

@SunRunAway
Copy link
Contributor

SunRunAway commented Aug 27, 2020

Description

Development Task

INSERT IGNORE from a table of 300,000 rows,

INSERT IGNORE INTO t SELECT * FROM t1

And we got the following slow query log.
image

Unfortunately, with this log, we have no clue where the time is consumed.

Then we must investigate this problem by using go profile or trace.

image

With the above go profile graph, I propose to add two extra time-consuming sections in runtime information and trace span,

  1. Check Duplicate, including getKeysNeedCheck and txn.Get from memory buffer, but except the RPC time.
  2. Add Records, for the memory operation of memtable.

SIG slack channel

#sig-exec

Score

  • 300

Mentor

@SunRunAway SunRunAway added the type/enhancement The issue or PR belongs to an enhancement. label Aug 27, 2020
@time-and-fate
Copy link
Member

/label sig/execution

@ti-srebot ti-srebot added the sig/execution SIG execution label Aug 27, 2020
@SunRunAway SunRunAway changed the title Record the time consuming of memory operation of Insert Executor in Slow Query Log Record the time consuming of memory operation of Insert Executor in Runtime Information Aug 27, 2020
@crazycs520
Copy link
Contributor

@jyz0309 PTAL

@jyz0309
Copy link
Contributor

jyz0309 commented Sep 23, 2020

/pick-up

@ti-challenge-bot
Copy link

Pick up success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge-program sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
5 participants