-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,ddl: update auto_random_base in 'show create table' after insertion #18217
Merged
Merged
Changes from 43 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
975cb41
executor,ddl: update auto_random_base in 'show create table' after in…
Rustin170506 57a4871
executor: fix logic
Rustin170506 be8b55e
executor: remove var
Rustin170506 117c600
executor: refine logic
Rustin170506 d0b6606
executor: refine logic
Rustin170506 8a230be
executor: fix sql
Rustin170506 62cb14a
executor: fix sql
Rustin170506 ce2fe25
executor: fix sql
Rustin170506 7c2bf61
executor: fix assert
Rustin170506 20fe777
executor: fix assert
Rustin170506 8405829
executor: add more cases
Rustin170506 167cf8d
executor: use different Allocator
Rustin170506 1c35b26
executor: use different Allocator
Rustin170506 6c3769c
executor: use different Allocator
Rustin170506 13127ae
executor: use different Allocator
Rustin170506 e957c45
executor: use different Allocator
Rustin170506 a60b9ce
executor: fix test
Rustin170506 1519e56
executor: refine logic
Rustin170506 8f24cff
Merge branch 'master' into rustin-patch-auto
Rustin170506 a061b04
executor: refine logic
Rustin170506 c7421c7
Merge branch 'master' into rustin-patch-auto
Rustin170506 79b6a2d
executor: fix type
Rustin170506 51f8084
executor: add blank line
Rustin170506 f10b42f
executor: add test config
Rustin170506 a5d5ae1
Merge branch 'master' into rustin-patch-auto
AilinKid 461e98c
Merge branch 'master' into rustin-patch-auto
Rustin170506 a72f5bd
executor: add test setup and Teardown
Rustin170506 582f249
executor: use test setup and Teardown
Rustin170506 b830703
executor: remove useless code
Rustin170506 5e56a80
executor: add failed point mock
Rustin170506 b156053
executor: remove failed point mock
Rustin170506 5869c8f
Merge branch 'master' into rustin-patch-auto
Rustin170506 606e3cf
executor: fix fmt
Rustin170506 d12e6c3
executor: fix fmt
Rustin170506 7f07d69
executor: add failed point mock
Rustin170506 11cd87e
executor: fix fmt
Rustin170506 8cf78e1
Merge branch 'master' into rustin-patch-auto
Rustin170506 77cb504
executor: using fixtures
Rustin170506 b5094f3
executor: using fixtures
Rustin170506 dd5b381
Merge branch 'master' into rustin-patch-auto
AilinKid 5c2a831
Merge branch 'master' into rustin-patch-auto
Rustin170506 c8aee99
Merge branch 'master' into rustin-patch-auto
Rustin170506 b3cd4e6
Merge branch 'master' into rustin-patch-auto
AilinKid a1d89c8
Merge branch 'master' into rustin-patch-auto
Rustin170506 b1d0dc8
Merge branch 'master' into rustin-patch-auto
Rustin170506 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep it stable, it is better to initialize the test (like other tests in
testAutoRandomSuite
):(If you would like to help improve, these patterns can be put into
SetupTest()
andTeardownTest()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Maybe I can send another PR to improve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better in the same PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored.