executor,ddl: update auto_random_base in 'show create table' after insertion #18217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sertion Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
github-actions
bot
added
sig/sql-infra
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #18217 +/- ##
===========================================
Coverage 79.4461% 79.4461%
===========================================
Files 535 535
Lines 144046 144046
===========================================
Hits 114439 114439
Misses 20343 20343
Partials 9264 9264 |
tangenta
reviewed
Jun 28, 2020
There was a problem hiding this comment.
Sorry for the unclear explanation. There are three types of allocator: RowIDAllocType, AutoIncrementType, and AutoRandomType.
Lines 73 to 82 in 3adb557
You can construct an auto_increment allocator for AUTO_INCREMENT = %d clause and an auto_random allocator for AUTO_RANDOM_BASE = %d clause.
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
|
@ti-srebot /run-all-tests |
|
/run-all-tests |
|
@ti-srebot /run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-test Data Race Log |
seems no business with this PR |
AilinKid
approved these changes
Jun 30, 2020
|
@AilinKid,Thanks for you review. |
|
@ti-srebot /run-all-tests |
1 task
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 1, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18304 |
|
@Rustin-Liu you can write directly to the cherry-pick pr to resolving the confilcts, which will do our a favor |
|
@AilinKid I will resolve it tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rustin-Liu rustin.liu@gmail.com
What problem does this PR solve?
Issue Number: close #17456。
Problem Summary:
What is changed and how it works?
What's Changed:
Use Allocator.NextGlobalAutoID() as auto_random_base.
How it Works:
Use Allocator.NextGlobalAutoID() as auto_random_base.
Related changes
Check List
Tests
Side effects
None
Release note