-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: add some information about the rewriting phase into the slow log #17569
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17569 +/- ##
================================================
- Coverage 79.5690% 79.5649% -0.0042%
================================================
Files 524 524
Lines 142250 142182 -68
================================================
- Hits 113187 113127 -60
- Misses 19968 19987 +19
+ Partials 9095 9068 -27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Remember to update the docs.
Ok, thx. |
/run-all-tests |
@qw4990 merge failed. |
/run-all-tests |
1 similar comment
/run-all-tests |
#17557 need to be re-opened :) |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #18164 |
What problem does this PR solve?
Issue Number: #17557
Problem Summary: add some information about the rewriting phase into the slow log
What is changed and how it works?
One step to resolve #17557.
Add three fields to slow logs:
For example, in this query:
The subquery is not related with the outside query so it will be processed during the rewriting phase.
After this PR, you can see this information in its slow log:
Related changes
pingcap/docs
/pingcap/docs-cn
: update the relative docs about the slow query.Check List
Tests
Release note