Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information in slow logs to help analyze slow queries #17557

Closed
9 of 10 tasks
Tracked by #18867
qw4990 opened this issue Jun 1, 2020 · 5 comments · Fixed by #17569 or #17869
Closed
9 of 10 tasks
Tracked by #18867

Add more information in slow logs to help analyze slow queries #17557

qw4990 opened this issue Jun 1, 2020 · 5 comments · Fixed by #17569 or #17869
Assignees
Labels
epic/slow-query type/enhancement The issue or PR belongs to an enhancement.
Milestone

Comments

@qw4990
Copy link
Contributor

qw4990 commented Jun 1, 2020

Development Task

Now information in slow logs(or slow-query-table) is not enough to analyze slow queries.
After discussing, we should add these useful information into it:

@qw4990 qw4990 added the type/enhancement The issue or PR belongs to an enhancement. label Jun 1, 2020
@SunRunAway
Copy link
Contributor

SunRunAway commented Jun 1, 2020

Should Statement Summary be involved?

@breezewish
Copy link
Member

@SunRunAway I opened an issue for the statement part. Some fields listed here are already included in the statements. TiDB should provide Slow Query and Statement fields in a unified way, i.e. they have identical fields (or mostly shares a common part) and names.

#17689

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 14, 2020

Since pingcap/kvproto#600 is not supported by TiKV, it is no use to support it on TiKV now, so we decide to close this issue now and support it after TiKV supporting it.

@qw4990 qw4990 closed this as completed Jul 14, 2020
@breezewish
Copy link
Member

Since pingcap/kvproto#600 is not supported by TiKV, it is no use to support it on TiKV now, so we decide to close this issue now and support it after TiKV supporting it.

@qw4990 There is a PR for it tikv/tikv#7563 Maybe we can drive this PR now.

@breezewish
Copy link
Member

@qw4990 Hi, are these new slow log fields available in v4.0 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/slow-query type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
3 participants