Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/admin: support admin check index on partition table (#17183) #17390

Merged
merged 4 commits into from
Jun 1, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 25, 2020

cherry-pick #17183 to release-3.0


Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

As title said.

Before this PR, admin check index on partition table will panic.

What is changed and how it works?

This PR removes the CheckIndexExec executor, and use CheckTableExec executor to do admin check index.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • Support admin check index on the partition table

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented May 25, 2020

/run-all-tests

@sre-bot sre-bot added sig/execution SIG execution component/util priority/release-blocker This issue blocks a release. Please solve it ASAP. type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels May 25, 2020
@sre-bot sre-bot added this to the v3.0.15 milestone May 25, 2020
Signed-off-by: crazycs <crazycs520@gmail.com>
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2020
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 1, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 1, 2020

@sre-bot merge failed.

@crazycs520
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

/rebuild

@bb7133 bb7133 merged commit c6a93de into pingcap:release-3.0 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/util priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants