util/admin: support admin check index on partition table #17183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
ghost
requested review from
|
@tiancaiamao @zimulala PTAL |
|
/run-unit-test |
…ycs520/tidb into admin-check-partition-index
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #17183 +/- ##
===========================================
Coverage 80.3230% 80.3230%
===========================================
Files 521 521
Lines 142908 142908
===========================================
Hits 114788 114788
Misses 19160 19160
Partials 8960 8960 |
crazycs520
added
needs-cherry-pick-4.0
priority/release-blocker
|
/run-unit-test |
|
LGTM |
tangenta
reviewed
May 14, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
bb7133
added
status/can-merge
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 25, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #17390 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 25, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #17391 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 25, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17392 |
jebter
pushed a commit
that referenced
this pull request
May 26, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com> Co-authored-by: crazycs <crazycs520@gmail.com>
bb7133
pushed a commit
that referenced
this pull request
Jun 1, 2020
zz-jason
pushed a commit
that referenced
this pull request
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Close #17398
As title said.
Before this PR,
admin check indexon partition table will panic.What is changed and how it works?
This PR removes the
CheckIndexExecexecutor, and useCheckTableExecexecutor to doadmin check index.Related changes
Check List
Tests
Side effects
Release note