ddl: add syntax for setting the cache step of auto id explicitly. (#15409) #16286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/sql-infra
zimulala
reviewed
Apr 10, 2020
| @@ -271,7 +271,11 @@ func convertJob2RollbackJob(w *worker, d *ddlCtx, t *meta.Meta, job *model.Job) | |||
| model.ActionModifyColumn, model.ActionAddForeignKey, | |||
| model.ActionDropForeignKey, model.ActionRenameTable, | |||
| model.ActionModifyTableCharsetAndCollate, model.ActionTruncateTablePartition, | |||
| <<<<<<< HEAD | |||
| model.ActionModifySchemaCharsetAndCollate: | |||
There was a problem hiding this comment.
Please fix the conflicts.
@AilinKid
|
blocked by some PR cherry-pick in Parser |
|
This 2.1 cherry-pick need some previous work cherry-picked first, I will follow it |
|
Closed because this feature is designed for release 3.0 + |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15409 to release-2.1
What problem does this PR solve?
That autoid allocator's cache step is quite big now, it will consume a lot of autoid when tidb restarts or crashes. For those scenes which treasure autoid heavily, it's not acceptable.
Parser link: #765
Problem Summary:
What is changed and how it works?
Add
auto_increment_cachein create table / alter table statement and it will determine the allocator's cache step.But there is an exception when a statement like an insert batch(
insert into values()()...) which requires allocating consecutive N autoid in one statement, we will make sure that the custom cache step is adequate for it withif step < N, then step = min(2N, maxstep)Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Check List
Tests
Release note:
ddl: add syntax for setting the cache step of auto id explicitly.