parser: add autoid cache option #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
=======================================
Coverage 78.21% 78.22%
=======================================
Files 40 40
Lines 14694 14700 +6
=======================================
+ Hits 11493 11499 +6
Misses 2520 2520
Partials 681 681 |
|
Is there a TiDB PR for this change? |
Yes，it's still work in process. |
After it's done, please link that PR with this one, so we can merge them together. @AilinKid |
bb7133
reviewed
Mar 17, 2020
parser.y
Outdated
| @@ -4884,6 +4885,7 @@ UnReservedKeyword: | |||
| | "ADVISE" | |||
| | "ASCII" | |||
| | "AUTO_INCREMENT" | |||
| | "AUTO_INCREMENT_CACHE" | |||
There was a problem hiding this comment.
Please rename it to AUTO_ID_CACHE, as you mentioned, it doesn't affect AutoIncrement column only.
|
Please address the comment and fix CI. |
|
LGTM, but let's hold it DNM until the TiDB PR is ready to merge. |
bb7133
approved these changes
Apr 10, 2020
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
This was referenced Apr 10, 2020
Closed
Merged
Merged
AilinKid
added a commit
to AilinKid/parser
that referenced
this pull request
Apr 11, 2020
AilinKid
added a commit
to AilinKid/parser
that referenced
this pull request
Apr 11, 2020
AilinKid
added a commit
to AilinKid/parser
that referenced
this pull request
Apr 11, 2020
AilinKid
added a commit
to AilinKid/parser
that referenced
this pull request
Apr 20, 2020
AilinKid
added a commit
that referenced
this pull request
Apr 22, 2020
AilinKid
added a commit
to AilinKid/parser
that referenced
this pull request
Apr 27, 2020
AilinKid
added a commit
that referenced
this pull request
Apr 27, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
By now, the auto-increment cache in TiDB is quite big for inserting performance.
In some cases, some table is used as a tool to generate some id, the autoid cache will miss when tidb crash or restart, which leading autoid increment quickly.
The related to pingcap/tidb#15409
That's why we support the auto-increment cache option.
What is changed and how it works?
Add
auto_increment_cachetable option.Make some test about it.
Check List
Tests
Related changes