Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/memory/tracker: Misleading log information when spilling to disk #15454

Closed
wants to merge 10 commits into from
Closed

util/memory/tracker: Misleading log information when spilling to disk #15454

wants to merge 10 commits into from

Conversation

yzwqf
Copy link
Contributor

@yzwqf yzwqf commented Mar 18, 2020

What problem does this PR solve?

#15401

What is changed and how it works?

Hide the unrelated quotas as the issue says.

Check List

Tests

  • Unit test
  • Integration test

@yzwqf yzwqf requested a review from a team as a code owner March 18, 2020 06:07
@ghost ghost requested review from qw4990 and XuHuaiyu and removed request for a team March 18, 2020 06:07
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 18, 2020
@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Mar 18, 2020
SunRunAway
SunRunAway reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Are the unrelated changes of infoschema added by mistake?

@yzwqf
Copy link
Contributor Author

yzwqf commented Mar 18, 2020 •
edited
Loading

Hi,
Are the unrelated changes of infoschema added by mistake?

yes, it is because of previous pr, i could create a new branch and commit again

@yzwqf yzwqf closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 Awaiting requested review from qw4990

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yzwqf @SunRunAway @sre-bot @zz-jason