Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading log information when spilling to disk #15401

Closed
SunRunAway opened this issue Mar 16, 2020 · 9 comments · Fixed by #15467
Closed

Misleading log information when spilling to disk #15401

SunRunAway opened this issue Mar 16, 2020 · 9 comments · Fixed by #15467
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.

Comments

@SunRunAway
Copy link
Contributor

SunRunAway commented Mar 16, 2020 •
edited
Loading

Description

  1. Set mem-quota-query to a small value, eg 32MB,
  2. Join a query (the usage of memory should be larger than mem-quota-query)

The log shows the quota of the root memory.Tracker is 32MB, and the quota of children is 32GB, which makes users confused.

image

What we should do,

  1. Hide those unrelated quotas.

Tips,

  1. The logging code is here,

    tidb/util/chunk/row_container.go

    Line 229 in 13bf6cc

    logutil.BgLogger().Info("memory exceeds quota, spill to disk now.", zap.String("memory", t.String()))

Score

  • 50

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • Golang Programming.

Learning Materials
@SunRunAway SunRunAway added type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement. labels Mar 16, 2020
@SunRunAway SunRunAway added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution labels Mar 16, 2020
@java2888
Copy link

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

@java2888 Please sign up before pick a challenge.
You can signing up by file a issue here https://github.com/tidb-challenge-program/register

@java2888
Copy link

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

@java2888 pick up issue success

@yzwqf
Copy link
Contributor

yzwqf commented Mar 18, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

@yzwqf already had picked #15036, finish it before pick up a new one.

@yzwqf
Copy link
Contributor

yzwqf commented Mar 18, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

@yzwqf pick up issue success

This was referenced Mar 18, 2020
Closed
Merged
@yzwqf yzwqf mentioned this issue Mar 23, 2020
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Apr 6, 2020

This pick has been automatically canceled after more than a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UCP: util/memory: fix misleading log information when spilling to disk
4 participants
@SunRunAway @java2888 @sre-bot @yzwqf