errno: move the error code from the parser/mysql to tidb/errno #15277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qw4990,
SunRunAway,
lzmhhh123 and
winoros
and removed request for
a team
github-actions
bot
added
sig/sql-infra
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #15277 +/- ##
===========================================
Coverage 80.4680% 80.4680%
===========================================
Files 503 503
Lines 133970 133970
===========================================
Hits 107803 107803
Misses 17736 17736
Partials 8431 8431 |
|
|
/run-all-tests
Not really... I mean the code compatibility, if we remove the parser exported function, the cherry-pick work would be trouble. |
lysu
reviewed
Mar 11, 2020
jackysp
approved these changes
Mar 11, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@tiancaiamao merge failed. |
|
/rebuild |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some times we need to define/modify the error code.
The error code is defined in the parser repo, so we need to update two repositories in a single PR, that's cumbersome.
I want to move the TiDB customed error back to the TiDB repo.
What is changed and how it works?
The error code is now defined in github/pingcap/tidb/errno
I have a PR to verify TiDB doesn't depend on parser/mysql errors anymore (it's not important to merge the PR or not).
From now on, don't add more error code to parser/mysql error definitions, use tidb/errno instead.
(We can choose to clean the parser repo or not)
Check List
Tests
Code changes
Side effects
Breaking backward compatibilityRelated changes
It's better to cherry-pick it to reduce conflict in the future.