Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql: clean up unused TiDB errcode #764

Merged
merged 4 commits into from
Mar 11, 2020
Merged

mysql: clean up unused TiDB errcode #764

merged 4 commits into from
Mar 11, 2020

Conversation

tiancaiamao
Copy link
Collaborator

@tiancaiamao tiancaiamao commented Mar 11, 2020 •
edited
Loading

What problem does this PR solve?

Move TiDB customed error code to the TiDB repo, so we don't need to change two repo in one PR in the future.

What is changed and how it works?

Clean up unused code after pingcap/tidb#15277

Check List

Tests

  • No code

Code changes

  • Has exported variable/fields change

Side effects

  • Breaking backward compatibility

@tiancaiamao tiancaiamao requested a review from a team March 11, 2020 02:51
@ghost ghost requested review from kennytm and removed request for a team March 11, 2020 02:51
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files          40       40           
  Lines       14418    14418           
=======================================
  Hits        11223    11223           
  Misses       2513     2513           
  Partials      682      682

@tiancaiamao tiancaiamao mentioned this pull request Mar 11, 2020
Merged
@sre-bot sre-bot mentioned this pull request Mar 11, 2020
Closed
@tiancaiamao tiancaiamao removed the DNM label Mar 11, 2020
@tiancaiamao tiancaiamao changed the title mysql: move customed errcode to github.com/pingcap/tidb/errno mysql: clean up customed errcode Mar 11, 2020
@tiancaiamao tiancaiamao changed the title mysql: clean up customed errcode mysql: clean up unused TiDB errcode Mar 11, 2020
lysu
lysu reviewed Mar 11, 2020
View reviewed changes
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Mar 11, 2020

LGTM

jackysp
jackysp approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 300cc00 into pingcap:master Mar 11, 2020
@tiancaiamao tiancaiamao deleted the errno branch March 11, 2020 08:04
@amyangfei amyangfei mentioned this pull request Mar 18, 2020
Merged
tiancaiamao added a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@tiancaiamao
mysql: clean up unused TiDB errcode (pingcap#764)
b996f80
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@tiancaiamao
mysql: clean up unused TiDB errcode (pingcap#764)
1bc694a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@coocood coocood coocood approved these changes

@jackysp jackysp jackysp approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @coocood @lysu @jackysp