Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: bind the func to memtableRetriever #15181

Merged
merged 7 commits into from
Mar 9, 2020

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Mar 6, 2020

Signed-off-by: Rustin-Liu rustin.liu@gmail.com

What problem does this PR solve?

Bind the func to memtableRetriever.

What is changed and how it works?

Bind the func to memtableRetriever.

Check List

Tests

  • Unit test

Code changes

None

Side effects

None

Related changes

PR: #14704

Release note

None

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 6, 2020
@zz-jason zz-jason added the sig/execution SIG execution label Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #15181 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15181   +/-   ##
===========================================
  Coverage   80.3923%   80.3923%           
===========================================
  Files           503        503           
  Lines        132851     132851           
===========================================
  Hits         106802     106802           
  Misses        17666      17666           
  Partials       8383       8383

@Rustin170506 Rustin170506 marked this pull request as ready for review March 6, 2020 10:48
@Rustin170506 Rustin170506 requested a review from a team as a code owner March 6, 2020 10:48
@ghost ghost requested review from SunRunAway and XuHuaiyu and removed request for a team March 6, 2020 10:48
@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

@Rustin170506
Copy link
Member Author

@zz-jason @SunRunAway PTAL~

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. sig/execution SIG execution and removed sig/execution SIG execution labels Mar 6, 2020
@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

@Rustin170506
Copy link
Member Author

Rustin170506 commented Mar 7, 2020

@reafans @crazycs520 PTAL~

@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 8, 2020

/run-all-tests

@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

/run-all-tests

@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

/run-all-tests

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@zz-jason
Copy link
Member

zz-jason commented Mar 9, 2020

@lonng @SunRunAway PTAL

@zz-jason zz-jason requested review from lonng and removed request for XuHuaiyu and zz-jason March 9, 2020 03:38
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng
Copy link
Contributor

lonng commented Mar 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

@Rustin-Liu merge failed.

@Rustin170506
Copy link
Member Author

@sre-bot /auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

@Rustin-Liu No command or invalid command

@lonng
Copy link
Contributor

lonng commented Mar 9, 2020

/run-all-tests

@lonng lonng merged commit 9afaef8 into pingcap:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants