infoschema: Migrate the infoschema's retrieving data logic for 'schemata' to executor #14704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expression: fixed json type for truncate (#13064)
|
/run-all-tests |
|
/run-unit-tests |
|
/run-all-tests |
|
/run-all-tests |
17 tasks
This was referenced Feb 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Infoschema contains too much logic for retrieving data, which is confusing, we need to migrate this part to the executor so that infoshema only contains schema information.
What is changed and how it works?
InfoschemaReaderExecstruct which implementExecutorinterface.memtableRetrieverstruct which implementmemTableRetrieverinterface.infoschema_reader.goto executor pkg, migrate thedataForSchemata()anddataForSchemata()from infoschema pkg to executor/infoschema_reader.goCheck List
Tests
Code changes