Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add statement deadlock detect duration (#14444) #14484

Merged
merged 3 commits into from
Jan 16, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 15, 2020

cherry-pick #14444 to release-3.0


Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

If it is sth wrong with the deadlock detector, e.g. very slow, we need to know it.

What is changed and how it works?

Add statement deadlock detect duration.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 15, 2020

/run-all-tests

@coocood
Copy link
Member

coocood commented Jan 15, 2020

LGTM

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng
Copy link
Contributor

lonng commented Jan 15, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 15, 2020

Sorry @lonng, you don't have permission to trigger auto merge event on this branch.

@bb7133 bb7133 added this to the v3.0.10 milestone Jan 16, 2020
@bb7133
Copy link
Member

bb7133 commented Jan 16, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 16, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 16, 2020

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Jan 16, 2020

/run-all-tests

@bb7133 bb7133 merged commit 1c279e9 into pingcap:release-3.0 Jan 16, 2020
@bb7133
Copy link
Member

bb7133 commented Jan 16, 2020

Hi @jackysp , please add Release Notes in your PR Description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants