metrics: add statement deadlock detect duration #14444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
lonng
reviewed
Jan 10, 2020
| @@ -90,6 +90,16 @@ var ( | |||
| Help: "Bucketed histogram of a transaction execution duration, including retry.", | |||
| Buckets: prometheus.ExponentialBuckets(0.001, 2, 20), // 1ms ~ 1049s | |||
| }, []string{LblSQLType, LblType}) | |||
|
|
|||
| StatementDeadlockDetectDuration = prometheus.NewHistogram( | |||
| prometheus.HistogramOpts{ | |||
There was a problem hiding this comment.
Do we need to add a label to distinct the point_get duration?
|
LGTM |
1 similar comment
|
LGTM |
coocood
approved these changes
Jan 15, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #14484 |
bb7133
pushed a commit
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
If it is sth wrong with the deadlock detector, e.g. very slow, we need to know it.
What is changed and how it works?
Add statement deadlock detect duration.
Check List
Tests
Code changes
Related changes