Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: make auto id minimum step larger (#12873) #12893

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Oct 23, 2019

cherry-pick #12873 to release-3.0


What problem does this PR solve?

Originally, the default minimum step of auto id is 1000. This may cause too many transaction for applying auto id when there are many write request suddenly.

What is changed and how it works?

Make minimum step of auto id larger. Every TiDB server will cache at least 30000 auto id.

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note

@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 23, 2019

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Oct 23, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 23, 2019

Your auto merge job has been accepted, waiting for 12891, 12892

Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 23, 2019

/run-all-tests

@ngaut
Copy link
Member

ngaut commented Oct 23, 2019

/merge

@jackysp jackysp merged commit 8c28d73 into pingcap:release-3.0 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/session status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants