Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: make auto id minimum step larger #12873

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

imtbkcat
Copy link

What problem does this PR solve?

Originally, the default minimum step of auto id is 1000. This may cause too many transaction for applying auto id when there are many write request suddenly.

What is changed and how it works?

Make minimum step of auto id larger. Every TiDB server will cache at least 30000 auto id.

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #12873 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12873   +/-   ##
===========================================
  Coverage   80.0913%   80.0913%           
===========================================
  Files           465        465           
  Lines        107119     107119           
===========================================
  Hits          85793      85793           
  Misses        14905      14905           
  Partials       6421       6421

Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat
Copy link
Author

/run-all-tests

@imtbkcat imtbkcat added component/session status/LGT1 Indicates that a PR has LGTM 1. labels Oct 22, 2019
@imtbkcat
Copy link
Author

/run-unit-test

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 22, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 23, 2019

cherry pick to release-2.1 in PR #12891

@sre-bot
Copy link
Contributor

sre-bot commented Oct 23, 2019

cherry pick to release-3.1 in PR #12892

@sre-bot
Copy link
Contributor

sre-bot commented Oct 23, 2019

cherry pick to release-3.0 in PR #12893

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/session status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants