Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinTanSig #12238

Merged
merged 4 commits into from
Sep 18, 2019
Merged

expression: implement vectorized evaluation for builtinTanSig #12238

merged 4 commits into from
Sep 18, 2019

Conversation

jacklightChen
Copy link
Contributor

What problem does this PR solve?

implement vectorized evaluation for builtinTanSig, for #12105

What is changed and how it works?

according to benchmark, about 2 times faster than before:

BenchmarkVectorizedBuiltinMathFunc/builtinTanSig-VecBuiltinFunc-8                         100000             13197 ns/op            0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinTanSig-NonVecBuiltinFunc-8                       50000             30528 ns/op            0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 17, 2019
zz-jason
zz-jason reviewed Sep 18, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/expression status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2019
XuHuaiyu
XuHuaiyu approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 6c0ec62 into pingcap:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacklightChen @sre-bot @zz-jason @XuHuaiyu